[MOD] Improved Trading Overview

[Simahn]

Does anyone know if this is still working?

[geostar1024]

Does anyone know if this is still working?

 

I haven't tested it yet with the latest version, but unless something has radically changed, it should be. The new installation method was designed to make the mod more robust to changes in the base game (by including just a hook to the new code rather than completely replacing the base game's file). I'll test it tonight and update accordingly.

[Simahn]

Does anyone know if this is still working?

 

I haven't tested it yet with the latest version, but unless something has radically changed, it should be. The new installation method was designed to make the mod more robust to changes in the base game (by including just a hook to the new code rather than completely replacing the base game's file). I'll test it tonight and update accordingly.

 

I just did. It works. Except:

They changed some of the png icon names, so they show up as missing texture. (I don't even know how to code LUA, but I managed to fix that myself) It's just stuff like purse.png got changed to bag.png etc.

And the profit tab is displaying "--" on everything. Despite that, it still works. Just knowing the stock makes it very useful.

[geostar1024]

 

I just did. It works. Except:

They changed some of the png icon names, so they show up as missing texture. (I don't even know how to code LUA, but I managed to fix that myself) It's just stuff like purse.png got changed to bag.png etc.

 

Ah, thanks, I'll update those tonight, then.

 

And the profit tab is displaying "--" on everything. Despite that, it still works. Just knowing the stock makes it very useful.

 

Only the Legendary-quality module shows profit; if you have a legendary module installed and it's not showing profit, then that's a bug that I'll have to look into. Or wait, did you mean that none of the table entries on the Routes tab are filled in properly (if so, a more troubling bug)? If possible, could you send/post a screenshot of your ship's module setup and what you see when the Routes tab is selected?

[Simahn]

 

I just did. It works. Except:

They changed some of the png icon names, so they show up as missing texture. (I don't even know how to code LUA, but I managed to fix that myself) It's just stuff like purse.png got changed to bag.png etc.

 

Ah, thanks, I'll update those tonight, then.

 

And the profit tab is displaying "--" on everything. Despite that, it still works. Just knowing the stock makes it very useful.

 

Only the Legendary-quality module shows profit; if you have a legendary module installed and it's not showing profit, then that's a bug that I'll have to look into. Or wait, did you mean that none of the table entries on the Routes tab are filled in properly (if so, a more troubling bug)? If possible, could you send/post a screenshot of your ship's module setup and what you see when the Routes tab is selected?

 

Haha, I just realized, was about to edit my post. I don't have a legendary which explains it.

The only problem is the icons. I've fixed it for you though, so you just have to update the attachment:

https://pastebin.com/uqT7pLSq

 

Here's a link to the differences between the original and what I've changed, just so you can see I didn't fuck anything up, only changed the filenames:

https://diff-online.com/view/5cb782f658939c4e2fef83e2

[Simahn]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts. Well, that is, until i sold the gold - then the trading route come up again.

I don't dont if this is a feature or a bug? Might be because I didn't have space for more cargo? Or no more money? But I was lucky that i remembered what post needed it.

[geostar1024]

 

I just did. It works. Except:

They changed some of the png icon names, so they show up as missing texture. (I don't even know how to code LUA, but I managed to fix that myself) It's just stuff like purse.png got changed to bag.png etc.

 

Ah, thanks, I'll update those tonight, then.

 

And the profit tab is displaying "--" on everything. Despite that, it still works. Just knowing the stock makes it very useful.

 

Only the Legendary-quality module shows profit; if you have a legendary module installed and it's not showing profit, then that's a bug that I'll have to look into. Or wait, did you mean that none of the table entries on the Routes tab are filled in properly (if so, a more troubling bug)? If possible, could you send/post a screenshot of your ship's module setup and what you see when the Routes tab is selected?

 

Haha, I just realized, was about to edit my post. I don't have a legendary which explains it.

The only problem is the icons. I've fixed it for you though, so you just have to update the attachment:

https://pastebin.com/uqT7pLSq

 

Here's a link to the differences between the original and what I've changed, just so you can see I didn't fuck anything up, only changed the filenames:

https://diff-online.com/view/5cb782f658939c4e2fef83e2

 

Much appreciated; I've updated the attachment to v0.31 incorporating your fixes. Thanks!

[geostar1024]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

[Simahn]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

Sorry you didn't get my edit in time.

As soon as I sell the gold I can see the trading route again.

[geostar1024]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

Sorry you didn't get my edit in time.

As soon as I sell the gold I can see the trading route again.

 

Oh, very interesting. Well, if you add cargo space, does the route display again? I'll have to look at the logic there again, as routes shouldn't hide themselves if you have insufficient cargo unless you set a filter for that.

[Simahn]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

Sorry you didn't get my edit in time.

As soon as I sell the gold I can see the trading route again.

 

Oh, very interesting. Well, if you add cargo space, does the route display again? I'll have to look at the logic there again, as routes shouldn't hide themselves if you have insufficient cargo unless you set a filter for that.

 

I just tried selling half my cargo, to see if that made any difference, it didn't. Only when I sell everything the trading route appears again.

I can record a video of the problem, if you'd like?

Let me just try and uninstall and install the module, to see if that works. Going to record this time, so you can see exactly what I mean.

[geostar1024]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

Sorry you didn't get my edit in time.

As soon as I sell the gold I can see the trading route again.

 

Oh, very interesting. Well, if you add cargo space, does the route display again? I'll have to look at the logic there again, as routes shouldn't hide themselves if you have insufficient cargo unless you set a filter for that.

 

I just tried selling half my cargo, to see if that made any difference, it didn't. Only when I sell everything the trading route appears again.

I can record a video of the problem, if you'd like?

 

And I assume that if you buy just one unit of a good, the trading route disappears? I don't think I need a video; the bug you're reporting seems clear enough. I'll check through the code and see what I can find.

[Simahn]

Okay, I think there is a bug.

It told me that there was a trading post selling gold and another one buying. 1000's of gold each.,

So i bought everything i could. But as soon as i bought the gold, every  trading route disappeared.

I was still able to sell the gold, but the route itself, in the trading window disappeared, despite there being more gold in stock both to buy and sell at both trading posts.

 

That is strange; if you uninstall and reinstall the module, and then jump to each trading post again, does the route come back?

Sorry you didn't get my edit in time.

As soon as I sell the gold I can see the trading route again.

 

Oh, very interesting. Well, if you add cargo space, does the route display again? I'll have to look at the logic there again, as routes shouldn't hide themselves if you have insufficient cargo unless you set a filter for that.

 

I just tried selling half my cargo, to see if that made any difference, it didn't. Only when I sell everything the trading route appears again.

I can record a video of the problem, if you'd like?

 

And I assume that if you buy just one unit of a good, the trading route disappears? I don't think I need a video; the bug you're reporting seems clear enough. I'll check through the code and see what I can find.

Alright. Tried selling half my cargo, tried buying just one and I tried just reinstalling the trading module, but the trading route always disappears.

Sometimes all trading routes disappear, sometimes it's just the route for the item I just bought. Just weird.