[0.31.1] Factory - Incorrect fighter error displayed

[Rinart73]

Avorion: 0.15.x (maybe even older) - 0.31.1

File: data\scripts\entity\merchants\factory.lua

 

Function "getFighterStartErrorMessage" incorrectly processes "FighterStartError.FighterNotFound", because it double checks for "FighterStartError.MaximumFightersStarted" instead (Line 2010):

 

function Factory.getFighterStartErrorMessage(code)

    if code == FighterStartError.NoError then
        return "No error."%_T
    elseif code == FighterStartError.NoHangar then
        return "No hangar!"%_T
    elseif code == FighterStartError.SquadNotFound then
        return "Squad not found!"%_T
    elseif code == FighterStartError.SquadEmpty then
        return "Squad empty!"%_T
    elseif code == FighterStartError.NoStartPosition then
        return "No start position!"%_T
    elseif code == FighterStartError.MaximumFightersStarted then
        return "Maximum fighters started!"%_T
    elseif code == FighterStartError.MaximumFightersStarted then
        return "Fighter not found!"%_T
    elseif code == FighterStartError.NoPilots then
        return "Not enough pilots!"%_T
    elseif code == FighterStartError.NoCrew then
        return "Not enough crew!"%_T
    elseif code == FighterStartError.NoFighterFound then
        return "No cargo shuttles!"%_T
    end

    return "Unknown error"%_T
end

 

Should be:

 

function Factory.getFighterStartErrorMessage(code)

    if code == FighterStartError.NoError then
        return "No error."%_T
    elseif code == FighterStartError.NoHangar then
        return "No hangar!"%_T
    elseif code == FighterStartError.SquadNotFound then
        return "Squad not found!"%_T
    elseif code == FighterStartError.SquadEmpty then
        return "Squad empty!"%_T
    elseif code == FighterStartError.NoStartPosition then
        return "No start position!"%_T
    elseif code == FighterStartError.MaximumFightersStarted then
        return "Maximum fighters started!"%_T
    elseif code == FighterStartError.FighterNotFound then
        return "Fighter not found!"%_T
    elseif code == FighterStartError.NoPilots then
        return "Not enough pilots!"%_T
    elseif code == FighterStartError.NoCrew then
        return "Not enough crew!"%_T
    elseif code == FighterStartError.NoFighterFound then
        return "No cargo shuttles!"%_T
    end

    return "Unknown error"%_T
end