Hi, just wanted to say thanks for this mod. Really made my day when I realised what a pain in the backside managing the salvaging fighters was :)
Couple of behaviours I noticed that could do with some improvements if possible:
1. Your code iterates all the salvageable wrecks and sets this in a variable salvagableWreck. This is always the salvage closest to the player ship. This has problems if the pieces of salvage closest to the ship are on opposite sides quite a long way away, as the fighters treaverse huge distances for a pebble before heading back.
You also have code in localizedFighterTarget() that does it for salvage closest to the fighter, but this called by
if not fighterT then
findAvailableFighter()
elseif localizedFighterTarget() then
localizedFighterTarget()
end
So it's called twice based on a boolean response of itself that it doesn't seem to supply? I'm not really familiar with lua so my understanding could be wrong here but this looks like a bug :P
From what I witness in game I'm guessing this function is never called as the fighters behave like the algorithm in the first function. My suggestion would be to ditch this function if possible, and the multiple iterations of the wreck collections. Instead, it would be better to do something like, check for wrecks first time, set a first check boolean to true, assign the targets and then next time a target check is needed compare the distances between the fighter and the wreck and the ship and the wreck, if it's closer to the fighter pick that. Else pick the one closer to the ship. This would stop the behaviour where wreck selection involves a lot of needless travelling when better targets are much closer.
2. As the fighers are set to a defensive task, as soon as a ship attacks your ship all the salvaging fightters head off to attack it. This is a bit of a pain and means that I tend ot lose fighters when I havent noticed and they are vary easy to blow up and quite hard to come by. I'm not sure if anything can be done about this as I have no knowledge of the game and it's scripting side at all, but would be a nice improvment if they can just ignore the fight :)
Thanks again, this mod has saved me loads of faff
