mine.lua and salvage.lua call setAIAction, but it doesn't work

[Rinart73]

When mining/salvaging AI ship can't find an asteroid/wreckage it does this:

 

ShipAI(ship.index):setPassive()
ship:invokeFunction("craftorders.lua", "setAIAction")

 

But CraftOrders.setAIAction calls checkEntityInteractionPermissions function:

local owner, _, player = checkEntityInteractionPermissions(Entity(), AlliancePrivilege.ManageShips)

this functions uses callingPlayer and since it's nil in this case, this check will not be passed and icon will not be changed.

 

Two ways to fix this:

 

1. To fake 'callingPlayer':

if ship.playerOwned then
    callingPlayer = ship.factionIndex
elseif ship.allianceOwned then
    callingPlayer = Alliance(ship.factionIndex).leader
end
ship:invokeFunction("craftorders.lua", "setAIAction")
callingPlayer = nil

 

2. To change checkEntityInteractionPermissions code so if callingPlayer is nil, the result of check is true